OK for me, 2 type testings:

1. stress testing with k6, will use golang to invoke via thrift interface.
2. jepsen

@critical27 is'it possible to add an append api?

@critical27 is'it possible to add an append api?

What is the purpose? Could, but the performance will be very poor.

Hi @critical27 plz solve the conflicts.

I think these pure kv interfaces are more suitable in separate client semantically?

do we support getPrefix or removePrefix ? generally LGTM

We can't do it just like a put/get, because we need to fan out to do prefix/removePrefix from all partition, think them as a lookup. But we could do it if really necessary.

LGTM. but why do we need to remove this GeneralStorageClient&Server? Maybe I need to modify my rpc modification to specific interface and keep a rpc server for those requests not from graph client, so that we can keep tools in different process.

The server do need to be removed, because we bind a service to a port separately, we have already used 4 ports. We definitely don't want to add a port more, the kv interface is mainly for test only.

I think these pure kv interfaces are more suitable in separate client semantically?

Ah... The reason is we don't want to add an extra service here. (we need one more extra port to bind), so both the service and client will be removed. In 1.0, they are in the same service as well.

Codecov Report

Merging #3282 (033a6a2) into master (6541438) will decrease coverage by 0.09%.
The diff coverage is 80.90%.

@@            Coverage Diff             @@
##           master    #3282      +/-   ##
==========================================
- Coverage   85.31%   85.22%   -0.10%     
==========================================
  Files        1289     1276      -13     
  Lines      120073   118982    -1091     
==========================================
- Hits       102442   101398    -1044     
+ Misses      17631    17584      -47     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14d7b4...033a6a2. Read the comment docs.